Skip to content

fix: preserve PHP 7.0-7.1 ZTS property names - #4185

Merged
morrisonlevi merged 1 commit into
masterfrom
levi/repro-7.1-zts-uaf-fix
Sep 11, 2026
Merged

fix: preserve PHP 7.0-7.1 ZTS property names#4185
morrisonlevi merged 1 commit into
masterfrom
levi/repro-7.1-zts-uaf-fix

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes a crash that happens during shutdown on PHP 7.0-7.11 on ZTS builds. This is happening a lot on the combined tracer+profiler branch, and I wanted it to get reviewed and merged independently since that PR is so big already, and it's not related to the branch.

Common symptom is:

*** Error in `/opt/php/7.1-zts/bin/php-cgi': corrupted double-linked list: 0x000000003662ec20 ***

Which happens in tsrm_shutdown.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 10, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 27 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | check libxml2 version — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.0] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.2] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 27 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 55.03% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2f333c2 | Docs | View more details | Give us feedback!

@morrisonlevi
morrisonlevi marked this pull request as ready for review September 10, 2026 22:14
@morrisonlevi
morrisonlevi requested review from a team as code owners September 10, 2026 22:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T22:18:32.125999Z 34667bb Draft marked ready
🔒 Security Review Completed 2026-09-10T22:19:20.707582Z 34667bb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pr-commenter

pr-commenter Bot commented Sep 10, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-09-11 16:15:33

Comparing candidate commit 2f333c2 in PR branch levi/repro-7.1-zts-uaf-fix with baseline commit fcbed87 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 194 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@morrisonlevi
morrisonlevi enabled auto-merge (squash) September 11, 2026 14:41
@morrisonlevi
morrisonlevi force-pushed the levi/repro-7.1-zts-uaf-fix branch from e1e74cc to 2f333c2 Compare September 11, 2026 14:54
@morrisonlevi morrisonlevi changed the title fix: preserve PHP 7.1 ZTS property names fix: preserve PHP 7.0-7.1 ZTS property names Sep 11, 2026
@morrisonlevi
morrisonlevi merged commit a0bf05c into master Sep 11, 2026
2178 of 2193 checks passed
@morrisonlevi
morrisonlevi deleted the levi/repro-7.1-zts-uaf-fix branch September 11, 2026 16:24
@github-actions github-actions Bot added this to the 1.26.0 milestone Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants